StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r257725839
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java
##########
@@ -181,7 +182,42 @@
keyGroupRange,
kvStateRegistry,
ttlTimeProvider,
- new UnregisteredMetricsGroup());
+ new UnregisteredMetricsGroup(),
+ null);
Review comment:
With the annotation you can drop the `null` checks, we consider this as
null-free code. That is also the same in other parts of Flink. Furthermore the
annotations are also compiled into assertions when running in test/debug mode
(enabled asserts) and your IDE will complain and mark it as problem if you try
to pass null into an annotated method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
