StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r257639195
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java
##########
@@ -181,7 +182,42 @@
keyGroupRange,
kvStateRegistry,
ttlTimeProvider,
- new UnregisteredMetricsGroup());
+ new UnregisteredMetricsGroup(),
+ null);
Review comment:
I think it would be better to use an empty collection over `null` and
document that this parameter is `@Nonnull`. There should be no need to a
different meaning between empty and `null` here, so it can prevent potential
NPEs and saves multiple null-checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
