StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r258051412
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -368,15 +289,18 @@ private static void checkAndCreateDirectory(File
directory) throws IOException {
@VisibleForTesting
ColumnFamilyHandle getColumnFamilyHandle(String state) {
- Tuple2<ColumnFamilyHandle, ?> columnInfo =
kvStateInformation.get(state);
- return columnInfo != null ? columnInfo.f0 : null;
+ StateColumnFamilyHandle columnInfo =
kvStateInformation.get(state);
+ return columnInfo != null ? columnInfo.getColumnFamilyHandle()
: null;
}
- private void registerKvStateInformation(String columnFamilyName,
Tuple2<ColumnFamilyHandle, RegisteredStateMetaInfoBase> registeredColumn) {
+ public static void registerKvStateInformation(Map<String,
StateColumnFamilyHandle> kvStateInformation,
Review comment:
Coule be moved to `RocksDBOperationUtils` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
