zentol commented on a change in pull request #7719: [FLINK-10569] Remove
Instance usage in ExecutionGraphDeploymentTest
URL: https://github.com/apache/flink/pull/7719#discussion_r258424799
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexDeploymentTest.java
##########
@@ -273,15 +270,7 @@ public void testFailExternallyDuringDeploy() {
}
};
- TestingLogicalSlot testingLogicalSlot =
- new TestingLogicalSlot(
- new LocalTaskManagerLocation(),
- blockSubmitGateway,
- 0,
- new AllocationID(),
- new SlotRequestId(),
- new SlotSharingGroupId(),
- null);
+ TestingLogicalSlot testingLogicalSlot = new
TestingLogicalSlot(blockSubmitGateway);
Review comment:
hmm................................since we're updating the test anyway in
another PR I'd move this change into that PR. btw, it might be a good idea to
change the first constructor (without any arguments) to call the new one, to
ensure they use the same defaults.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
