zentol commented on a change in pull request #7719: [FLINK-10569] Remove
Instance usage in ExecutionGraphDeploymentTest
URL: https://github.com/apache/flink/pull/7719#discussion_r258818389
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
##########
@@ -44,23 +47,21 @@
private final String address = UUID.randomUUID().toString();
- private Optional<Consumer<ExecutionAttemptID>> optSubmitConsumer;
+ private Consumer<TaskDeploymentDescriptor> submitConsumer = ignore -> {
};
- private Optional<Consumer<ExecutionAttemptID>> optCancelConsumer;
+ private Consumer<ExecutionAttemptID> cancelConsumer = ignore -> { };
private volatile BiFunction<AllocationID, Throwable,
CompletableFuture<Acknowledge>> freeSlotFunction;
- public SimpleAckingTaskManagerGateway() {
- optSubmitConsumer = Optional.empty();
- optCancelConsumer = Optional.empty();
- }
+ @Nonnull
+ private volatile BiConsumer<InstanceID, Exception>
disconnectFromJobManagerConsumer = (ignoredA, ignoredB) -> {};
Review comment:
Where does this come from? Hmm it exists in master, so I suppose it's either
a GH bug or something went wrong during a rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
