rmetzger commented on a change in pull request #7609: [FLINK-11642]
[flink-s3-fs-hadoop] Add mirrored config key for s3 endpoint
URL: https://github.com/apache/flink/pull/7609#discussion_r258427560
##########
File path:
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java
##########
@@ -51,7 +51,8 @@
private static final String[][] MIRRORED_CONFIG_KEYS = {
{ "fs.s3a.access-key", "fs.s3a.access.key" },
- { "fs.s3a.secret-key", "fs.s3a.secret.key" }
+ { "fs.s3a.secret-key", "fs.s3a.secret.key" },
+ { "fs.s3a.endpoint", "fs.s3a.endpoint" }
Review comment:
I don't understand why we need to add this config key to the list of
mirrored keys.
Isn't the purpose of the mirroring to map between Hadoop's keys and internal
keys (of say Presto)?
If I'm commenting out this change, the new tests are still passing (which
makes sense, because the config keys are just forwarded)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
