rmetzger commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-465527415 Thank you for all the comment addressing you've done! Sorry for not being active on the PR yesterday. I had to take care of some other things. I believe we should try to use the Sync API, because it is, as you say as well, the cleaner approach. I will be able to test it as well on Google. Whether we get it into the release or not is very hard to predict at this point. If we are "lucky", the release get's delayed. If not, I'm committed to keep pushing on this PR, so that we merge it as soon as we can (even if it is 2 days after the 1.8 feature freeze). So I suggest to keep pushing, maybe we manage to get it into 1.8. My biggest headache are currently the changes to the existing codebase of Flink (outside this connector). If this PR would just add a connector without touching anything else, I would probably be more comfortable merging it. If we decide to keep those changes in, I will probably not merge this PR if I'm not getting a solid review by somebody who knows the RabbitMQ / acknowledging base code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
