tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r258478341
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -324,6 +325,10 @@ private void requestSlotFromResourceManager(
// been completed with another
allocated slot
resourceManagerGateway.cancelSlotRequest(allocationId);
}
+
+ if (throwable instanceof
MaximumFailedTaskManagerExceedingException) {
+ throw
(MaximumFailedTaskManagerExceedingException) throwable;
+ }
Review comment:
This code should not do anything. Why did you add it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
