tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r258467118
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -149,25 +150,26 @@
private MesosConfiguration initializedMesosConfig;
public MesosResourceManager(
- // base class
- RpcService rpcService,
- String resourceManagerEndpointId,
- ResourceID resourceId,
- HighAvailabilityServices highAvailabilityServices,
- HeartbeatServices heartbeatServices,
- SlotManager slotManager,
- MetricRegistry metricRegistry,
- JobLeaderIdService jobLeaderIdService,
- ClusterInformation clusterInformation,
- FatalErrorHandler fatalErrorHandler,
- // Mesos specifics
- Configuration flinkConfig,
- MesosServices mesosServices,
- MesosConfiguration mesosConfig,
- MesosTaskManagerParameters taskManagerParameters,
- ContainerSpecification taskManagerContainerSpec,
- @Nullable String webUiUrl,
- JobManagerMetricGroup jobManagerMetricGroup) {
+ // base class
+ RpcService rpcService,
+ String resourceManagerEndpointId,
+ ResourceID resourceId,
+ HighAvailabilityServices highAvailabilityServices,
+ HeartbeatServices heartbeatServices,
+ SlotManager slotManager,
+ MetricRegistry metricRegistry,
+ JobLeaderIdService jobLeaderIdService,
+ ClusterInformation clusterInformation,
+ FatalErrorHandler fatalErrorHandler,
+ // Mesos specifics
+ Configuration flinkConfig,
+ MesosServices mesosServices,
+ MesosConfiguration mesosConfig,
+ MesosTaskManagerParameters taskManagerParameters,
+ ContainerSpecification taskManagerContainerSpec,
+ @Nullable String webUiUrl,
+ JobManagerMetricGroup jobManagerMetricGroup,
+ FailureRater failureRater) {
Review comment:
Let's move this parameter into the non-mesos specific section by adding it
after `fatalErrorHandler`, for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
