StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r259016651
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -449,12 +364,15 @@ public void dispose() {
cleanInstanceBasePath();
}
+ this.disposed = true;
}
private static void addColumnFamilyToCloseLater(
List<ColumnFamilyOptions> columnFamilyOptions,
ColumnFamilyHandle columnFamilyHandle) {
-
try {
+ if (columnFamilyHandle == null ||
columnFamilyHandle.getDescriptor() == null) {
Review comment:
why do we suddenly need those checks? I would assume that all arguments are
never null, the code should be null-free. If there is not a good reason why we
need the check, I would remove it because it can make you doubt if the
arguments _might_ be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
