StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r259027124
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -449,12 +364,15 @@ public void dispose() {
cleanInstanceBasePath();
}
+ this.disposed = true;
}
private static void addColumnFamilyToCloseLater(
List<ColumnFamilyOptions> columnFamilyOptions,
ColumnFamilyHandle columnFamilyHandle) {
-
try {
+ if (columnFamilyHandle == null ||
columnFamilyHandle.getDescriptor() == null) {
Review comment:
I think it would be good if we can avoid introducing null-checks in
production code that are only needed for tests. I would suggest to rather
ensure that the test does not pass in nulls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
