pnowojski commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r262484842
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -196,10 +198,152 @@ public void testSerializerClearedAfterClearBuffers()
throws Exception {
}
/**
- * Tests broadcasting events when no records have been emitted yet.
+ * Tests broadcasting events when no records have been emitted yet in
{@link BroadcastRecordWriter}.
*/
@Test
- public void testBroadcastEventNoRecords() throws Exception {
+ public void testBroadcastWriterBroadcastEventNoRecord() throws
Exception {
Review comment:
I would move `BroadcastRecordWriter`s test to `BroadcastRecordWriterTest`
class, that would extend from `RecordWriterTest`. `BroadcastRecordWriterTest`
could either override some `createRecordWriter()` method or pass different flag
in the constructor like:
```
public BroadcastRecordWriterTest() {
super(isBroadcastWriter = true);
}
```
It would simplify the code and would avoid the need for defining each test
method three times (broadcast, non broadcast, generic).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
