pnowojski commented on a change in pull request #7713: [FLINK-10995][network]
Copy intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r262926200
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -196,10 +198,152 @@ public void testSerializerClearedAfterClearBuffers()
throws Exception {
}
/**
- * Tests broadcasting events when no records have been emitted yet.
+ * Tests broadcasting events when no records have been emitted yet in
{@link BroadcastRecordWriter}.
*/
@Test
- public void testBroadcastEventNoRecords() throws Exception {
+ public void testBroadcastWriterBroadcastEventNoRecord() throws
Exception {
Review comment:
You can also override a base test with an empty method, marked overridden
method `@Ignore` or have abstract base class, with two concrete
`RecordWriterTest` and `BroadcastRecordWriterTest`. But maybe you are right,
that the approach that you've taken now might be simpler/easier, so you would
have to play with the code and use your own judgement here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
