[ 
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721918#comment-14721918
 ] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user ffbin commented on the pull request:

    https://github.com/apache/flink/pull/1046#issuecomment-136241503
  
    @mjsax @StephanEwen I have finish the code changes.
    1.serialize Storm Config as a byte[] into the Flink configuration
    2.extend ExclamationTopology such that the number of added !in 
ExclamationBolt and ExclamationWithStormSpout.ExclamationMap is configurable 
and adapt the tests.
    3.extend FiniteStormFileSpout and base class with an empty constructor and 
configure the file to be opened via Storm configuration Map.
    I have run flink-storm-compatibility test successfully in local machine and 
do not know why CI failed.
    Can you have a look at my code? Thank you very much.


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and 
> `Bolt.prepare()`, respectively. Both methods have a config `Map` as first 
> parameter. This map is currently not populated. Thus, Spouts and Bolts cannot 
> be configure with user defined parameters. In order to support this feature, 
> spout and bolt wrapper classes need to be extended to create a proper `Map` 
> object. Furthermore, the clients need to be extended to take a `Map`, 
> translate it into a Flink `Configuration` that is forwarded to the wrappers 
> for proper initialization of the map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to