dawidwys commented on a change in pull request #8006: [FLINK-11068][table]
Convert the API classes of *Table to interfaces
URL: https://github.com/apache/flink/pull/8006#discussion_r266882479
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResult.java
##########
@@ -53,11 +54,13 @@
private volatile boolean snapshotted = false;
- public MaterializedCollectBatchResult(TypeInformation<Row> outputType,
ExecutionConfig config) {
+ public MaterializedCollectBatchResult(RowTypeInfo outputType,
ExecutionConfig config) {
this.outputType = outputType;
accumulatorName = new AbstractID().toString();
- tableSink = new CollectBatchTableSink(accumulatorName,
outputType.createSerializer(config));
+ tableSink =
Review comment:
How about we change the return type of `configure` in
`CollectBatchTableSink` to `CollectBatchTableSink`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
