dawidwys commented on a change in pull request #8006: [FLINK-11068][table]
Convert the API classes of *Table to interfaces
URL: https://github.com/apache/flink/pull/8006#discussion_r266880371
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ResultStore.java
##########
@@ -61,7 +60,7 @@ public ResultStore(Configuration flinkConfig) {
*/
public <T> DynamicResult<T> createResult(Environment env, TableSchema
schema, ExecutionConfig config) {
- final TypeInformation<Row> outputType =
Types.ROW_NAMED(schema.getFieldNames(), schema.getFieldTypes());
+ final RowTypeInfo outputType = (RowTypeInfo)
Types.ROW_NAMED(schema.getFieldNames(), schema.getFieldTypes());
Review comment:
Maybe let's just replace it with the `RowTypeInfo` ctor, if we expect that
type anyway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
