zentol commented on a change in pull request #7927: [FLINK-11603][metrics] Port
the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r267347589
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
##########
@@ -76,10 +77,12 @@
ScopeFormats getScopeFormats();
/**
- * Returns the path of the {@link MetricQueryService} or null, if none
is started.
+ * Returns the gateway of the {@link MetricQueryService} or null, if
none is started.
*
- * @return Path of the MetricQueryService or null, if none is started
+ * @return Gateway of the MetricQueryService or null, if none is started
*/
@Nullable
- String getMetricQueryServicePath();
+ default MetricQueryServiceGateway getMetricQueryServiceGateway() {
+ return null;
Review comment:
seems unnecessary to have this as a default method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
