zentol commented on a change in pull request #7927: [FLINK-11603][metrics] Port 
the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r269476323
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 ##########
 @@ -207,16 +205,6 @@ public void start() throws Exception {
                                exception = ExceptionUtils.firstOrSuppressed(e, 
exception);
                        }
 
-                       try {
-                               metricRegistry.shutdown();
 
 Review comment:
   why are you changing the shutdown order?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to