[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725881#comment-14725881
]
ASF GitHub Bot commented on FLINK-2525:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38456958
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/AbstractStormSpoutWrapper.java
---
@@ -97,9 +106,42 @@ public AbstractStormSpoutWrapper(final IRichSpout spout,
}
@Override
+ public void open(Configuration parameters) throws Exception {
+ stormConf = new HashMap();
+
+ /* parameters is task configuration, we can get storm
configuration only from job configuration */
+ RuntimeContext ctx = super.getRuntimeContext();
+ if (ctx instanceof StreamingRuntimeContext) {
+ Configuration jobConfiguration =
((StreamingRuntimeContext) ctx).getJobConfiguration();
+
--- End diff --
I see. Would it be better to add Storm config to the task-config to
simplify code in `open(...)` method? For `FlinkTopology` the same config would
be added to each Spout/Bolt. At least for embedded mode, using task-config
instead of job-config would be more appropriate IMHO.
> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
> Key: FLINK-2525
> URL: https://issues.apache.org/jira/browse/FLINK-2525
> Project: Flink
> Issue Type: New Feature
> Components: Storm Compatibility
> Reporter: fangfengbin
> Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and
> `Bolt.prepare()`, respectively. Both methods have a config `Map` as first
> parameter. This map is currently not populated. Thus, Spouts and Bolts cannot
> be configure with user defined parameters. In order to support this feature,
> spout and bolt wrapper classes need to be extended to create a proper `Map`
> object. Furthermore, the clients need to be extended to take a `Map`,
> translate it into a Flink `Configuration` that is forwarded to the wrappers
> for proper initialization of the map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
