[ 
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733432#comment-14733432
 ] 

ASF GitHub Bot commented on FLINK-2525:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1046#discussion_r38844654
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapperTest.java
 ---
    @@ -222,6 +242,64 @@ public void testOpenSink() throws Exception {
     
        @SuppressWarnings("unchecked")
        @Test
    +   public void testOpenWithStormConf() throws Exception {
    +           final IRichBolt bolt = mock(IRichBolt.class);
    +           final StormBoltWrapper<Object, Object> wrapper = new 
StormBoltWrapper<Object, Object>(bolt);
    +
    +           Map stormConf = new HashMap();
    +           stormConf.put(new String("path"), new 
String("/home/user/file.txt"));
    --- End diff --
    
    Just use `"path`" here.


> Add configuration support in Storm-compatibility
> ------------------------------------------------
>
>                 Key: FLINK-2525
>                 URL: https://issues.apache.org/jira/browse/FLINK-2525
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>
> Spouts and Bolt are initialized by a call to `Spout.open(...)` and 
> `Bolt.prepare()`, respectively. Both methods have a config `Map` as first 
> parameter. This map is currently not populated. Thus, Spouts and Bolts cannot 
> be configure with user defined parameters. In order to support this feature, 
> spout and bolt wrapper classes need to be extended to create a proper `Map` 
> object. Furthermore, the clients need to be extended to take a `Map`, 
> translate it into a Flink `Configuration` that is forwarded to the wrappers 
> for proper initialization of the map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to