azagrebin commented on a change in pull request #8063: [hotfix] Remove unused 
construction and IOMode from NetworkEnvironmentConfiguration
URL: https://github.com/apache/flink/pull/8063#discussion_r269627442
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
 ##########
 @@ -384,13 +383,6 @@ private static NetworkEnvironmentConfiguration 
parseNetworkEnvironmentConfigurat
                        ConfigConstants.TASK_MANAGER_NETWORK_DEFAULT_IO_MODE,
 
 Review comment:
   I guess we can also delete the option `syncOrAsync` and 
`TASK_MANAGER_NETWORK_DEFAULT_IO_MODE` and `IOManager.IOMode` enum.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to