azagrebin commented on a change in pull request #8063: [hotfix] Remove unused
construction and IOMode from NetworkEnvironmentConfiguration
URL: https://github.com/apache/flink/pull/8063#discussion_r269973269
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
##########
@@ -283,12 +283,6 @@
@Deprecated
public static final String TASK_MANAGER_MEMORY_SEGMENT_SIZE_KEY =
"taskmanager.memory.segment-size";
- /**
- * The implementation to use for spillable/spilled intermediate
results, which have both
- * synchronous and asynchronous implementations: "sync" or "async".
- */
- public static final String TASK_MANAGER_NETWORK_DEFAULT_IO_MODE =
"taskmanager.network.defaultIOMode";
Review comment:
@zhijiangW
it seems we have to annotate those config constants as `@Deprecated` and add
a doc `@deprecated` comment that the option is not used anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
