zentol commented on a change in pull request #7927: [FLINK-11603][metrics] Port
the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r270019591
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -159,7 +157,7 @@ public TaskManagerRunner(Configuration configuration,
ResourceID resourceId) thr
this.terminationFuture = new CompletableFuture<>();
this.shutdown = false;
- MemoryLogger.startIfConfigured(LOG, configuration,
metricQueryServiceActorSystem);
+ MemoryLogger.startIfConfigured(LOG, configuration,
((AkkaRpcService) metricQueryServiceRpcService).getActorSystem());
Review comment:
The existing code is a bit odd; it should've never passed the MQS actor
system but that of the RPC service, since that one more closely resembles the
process as a whole.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
