zentol commented on a change in pull request #7927: [FLINK-11603][metrics] Port
the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r270384272
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -851,8 +852,8 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
}
@Override
- public CompletableFuture<SerializableOptional<String>>
requestMetricQueryServiceAddress(Time timeout) {
- return
CompletableFuture.completedFuture(SerializableOptional.ofNullable(metricQueryServicePath));
+ public CompletableFuture<Optional<MetricQueryServiceGateway>>
requestMetricQueryServiceGateway(Time timeout) {
Review comment:
You can't just add `Serializable` to a class and expect it to magically
work. The `MQS` extends `RpcEndpoint` which is not serialiable and contains
loads of fields that are neither.
From what i can tell we have to return the RpcService address instead, but
again, let me investigate first before making any changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
