TisonKun commented on a change in pull request #7927: [FLINK-11603][metrics]
Port the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r270382585
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -851,8 +852,8 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
}
@Override
- public CompletableFuture<SerializableOptional<String>>
requestMetricQueryServiceAddress(Time timeout) {
- return
CompletableFuture.completedFuture(SerializableOptional.ofNullable(metricQueryServicePath));
+ public CompletableFuture<Optional<MetricQueryServiceGateway>>
requestMetricQueryServiceGateway(Time timeout) {
Review comment:
Is using `SerializableOptional` reasonable? It causes we implements
`Serializable` for `MetricQueryServiceGateway` and thus for
`MetricQueryService`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
