TisonKun commented on a change in pull request #7927: [FLINK-11603][metrics] 
Port the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r268377229
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java
 ##########
 @@ -217,7 +205,7 @@ private void logDumpSizeWouldExceedLimit(final String 
metricType, boolean hasExc
         *     <li>{@code space : . ,} are replaced by {@code _} 
(underscore)</li>
         * </ul>
         */
-       static String replaceInvalidChars(String str) {
+       private static String replaceInvalidChars(String str) {
 
 Review comment:
   reverted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to