azagrebin commented on a change in pull request #8095: [FLINK-12078][network]
Abstract TaskEventPublisher interface for simplifying NetworkEnvironment
URL: https://github.com/apache/flink/pull/8095#discussion_r270964380
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -386,6 +391,8 @@ public Task(
ioManager,
desc.sendScheduleOrUpdateConsumersMessage());
+ taskEventDispatcher.registerPartition(partitionId);
Review comment:
I would preserve it how it is now and do `registerPartition` after
`network.registerTask` in `Task.run`, also to pair it with
`unregisterPartition` happening in finally block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
