azagrebin commented on a change in pull request #8095: [FLINK-12078][network] 
Abstract TaskEventPublisher interface for simplifying NetworkEnvironment
URL: https://github.com/apache/flink/pull/8095#discussion_r270968264
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ##########
 @@ -396,7 +409,8 @@ private static MemoryManager createMemoryManager(
         */
        private static NetworkEnvironment createNetworkEnvironment(
                        TaskManagerServicesConfiguration 
taskManagerServicesConfiguration,
-                       long maxJvmHeapMemory) {
+                       long maxJvmHeapMemory,
+                       TaskEventDispatcher taskEventDispatcher) {
 
 Review comment:
   can be also `TaskEventPublisher`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to