zhijiangW commented on a change in pull request #8090: [FLINK-12067][network]
Refactor the constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#discussion_r272012531
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -616,10 +394,9 @@ public static long calculateHeapSizeMB(long
totalJavaMemorySizeMB, Configuration
Preconditions.checkArgument(totalJavaMemorySizeMB > 0);
// subtract the Java memory used for network buffers (always
off-heap)
- final long networkBufMB =
- calculateNetworkBufferMemory(
- totalJavaMemorySizeMB << 20, // megabytes to
bytes
- config) >> 20; // bytes to megabytes
+ final long networkBufMB =
NetworkEnvironmentConfiguration.calculateNetworkBufferMemory(
Review comment:
Yes, it might be. Then we further focus on it future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
