azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers 
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r273415089
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -926,10 +926,11 @@ private boolean transitionState(ExecutionState 
currentState, ExecutionState newS
         * This method never blocks.
         * </p>
         *
+        * @return a Future representing pending completion of the task.
         * @throws UnsupportedOperationException if the {@link 
AbstractInvokable} does not implement {@link StoppableTask}
         * @throws IllegalStateException if the {@link Task} is not yet running
         */
-       public void stopExecution() {
+       public CompletableFuture<Void> stopExecution() {
 
 Review comment:
   let's revert this change as it does not seem to be related anymore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to