azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r273414876
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -337,7 +348,8 @@ public void start() throws Exception {
return FutureUtils.completedExceptionally(new
FlinkException("Error while shutting the TaskExecutor down.", throwable));
} else {
log.info("Stopped TaskExecutor {}.", getAddress());
- return CompletableFuture.completedFuture(null);
+ return
CompletableFuture.allOf(cancelingTaskFutures.toArray(
Review comment:
We also have a shorthand: `FutureUtils.waitForAll()`.
To fix the originally encountered failure
([FLINK-11631](https://issues.apache.org/jira/browse/FLINK-11631)), it looks
like we have put:
```
taskExecutorServices.shutDown();
fileCache.shutdown();
taskManagerMetricGroup.close();
```
after all tasks have terminated into the callback of joined future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
