tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait
for job termination before recovery in Dispatcher
URL: https://github.com/apache/flink/pull/7889#discussion_r262437718
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -351,7 +356,8 @@ private JobManagerRunner
startJobManagerRunner(JobManagerRunner jobManagerRunner
(ArchivedExecutionGraph archivedExecutionGraph,
Throwable throwable) -> {
// check if we are still the active
JobManagerRunner by checking the identity
//noinspection ObjectEquality
- if (jobManagerRunner ==
jobManagerRunnerFutures.get(jobId).getNow(null)) {
Review comment:
Agreed, please revert this change only introduces `r` which is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
