tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait
for job termination before recovery in Dispatcher
URL: https://github.com/apache/flink/pull/7889#discussion_r262440942
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -283,7 +282,13 @@ private void stopDispatcherServices() throws Exception {
return FutureUtils.completedExceptionally(
new JobSubmissionException(jobId,
String.format("Job has already been submitted and is in state %s.",
jobSchedulingStatus)));
} else {
- final CompletableFuture<Acknowledge>
persistAndRunFuture = waitForTerminatingJobManager(jobId, jobGraph,
this::persistAndRunJob)
+ final CompletableFuture<Acknowledge>
persistAndRunFuture = getJobTerminationFuture(jobId)
+ .thenComposeAsync(
+
FunctionUtils.uncheckedFunction((ignored) -> {
+
jobManagerTerminationFutures.remove(jobId);
Review comment:
why do we have to spread the removal of the job manager termination futures
all over the place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
