JingsongLi commented on a change in pull request #8109:
[FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to
StreamTransformation
URL: https://github.com/apache/flink/pull/8109#discussion_r273775150
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/SortCodeGenerator.scala
##########
@@ -478,6 +478,7 @@ class SortCodeGenerator(
case InternalTypes.FLOAT => 4
case InternalTypes.DOUBLE => 8
case InternalTypes.LONG => 8
+ case _: TimestampType => 8
Review comment:
Add
case _: DateType => 4
case InternalTypes.TIME => 4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
