JingsongLi commented on a change in pull request #8109:
[FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to
StreamTransformation
URL: https://github.com/apache/flink/pull/8109#discussion_r273777288
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryWriter.java
##########
@@ -102,7 +103,7 @@ static void write(BinaryWriter writer, int pos, Object o,
InternalType type) {
writer.writeInt(pos, (int) o);
} else if (type.equals(InternalTypes.TIME)) {
writer.writeInt(pos, (int) o);
- } else if (type.equals(InternalTypes.TIMESTAMP)) {
+ } else if (type instanceof TimestampType) {
Review comment:
modify `type instanceof DateType` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
