azagrebin commented on a change in pull request #7809: [FLINK-11710][tests]
Refactor SimpleSlotProvider to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#discussion_r275384640
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/TestingLogicalSlotProvider.java
##########
@@ -53,30 +52,31 @@
/**
* A testing utility slot provider that simply has a predefined pool of slots.
*/
-public class SimpleSlotProvider implements SlotProvider, SlotOwner {
+public class TestingLogicalSlotProvider implements SlotProvider, SlotOwner {
Review comment:
Having `LogicalSlot` also does not seem to add any info to its name, all
`SlotProvider`s provide `LogicalSlot`s. In this case, having only one
`SimpleSlotProvider` is actually more clear because it says that it is the most
obvious implementation of `SlotProvider`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
