azagrebin commented on a change in pull request #7809: [FLINK-11710][tests]
Refactor SimpleSlotProvider to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#discussion_r275389622
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SettableSlotContext.java
##########
@@ -26,9 +26,9 @@
import org.apache.flink.util.Preconditions;
/**
- * Simple implementation of the {@link SlotContext} interface for the legacy
code.
+ * A settable implementation of the {@link SlotContext} interface.
*/
-public class SimpleSlotContext implements SlotContext {
+public class SettableSlotContext implements SlotContext {
Review comment:
I would also lean towards having it in test package and name it
`TestingSlotContext` but it is still part of legacy code.
`SettableLeaderRetrievalService` looks like something you can manually set or
notify. `SimpleSlotContext` is just a simple wrapper of final variables, what
is to be set there? I would leave the name like it is now and rename it to
`TestingSlotContext` when it is used only in tests and it is possible to move
to it to test package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
