sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement
the runtime handling of the InputSelectable interface
URL: https://github.com/apache/flink/pull/8124#discussion_r275393059
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
##########
@@ -197,22 +217,23 @@ public void requestPartitions() throws IOException,
InterruptedException {
return Optional.of(bufferOrEvent);
}
- @Override
- public Optional<BufferOrEvent> pollNextBufferOrEvent() throws
UnsupportedOperationException {
- throw new UnsupportedOperationException();
- }
-
- private InputGateWithData waitAndGetNextInputGate() throws IOException,
InterruptedException {
+ private InputGateWithData waitAndGetNextInputGate(boolean blocking)
throws IOException, InterruptedException {
Review comment:
> if you can not measure the performance difference, then just don't bother
(avoid premature optimisations)
Okay, here I will change to return `Optional<...>`.
> I could believe that using Optional in NetworkInput#pollNextElement()
might cause performance issues, but please double check that.
At testing to use `Optional` in `NetworkInput#pollNextElement()`, I did as
you said.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
