dawidwys commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r276164933
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
##########
@@ -100,65 +100,36 @@ class RowtimeValidator(
object RowtimeValidator {
- val ROWTIME = "rowtime"
- val ROWTIME_TIMESTAMPS_TYPE = "rowtime.timestamps.type"
- val ROWTIME_TIMESTAMPS_TYPE_VALUE_FROM_FIELD = "from-field"
- val ROWTIME_TIMESTAMPS_TYPE_VALUE_FROM_SOURCE = "from-source"
- val ROWTIME_TIMESTAMPS_TYPE_VALUE_CUSTOM = "custom"
- val ROWTIME_TIMESTAMPS_FROM = "rowtime.timestamps.from"
- val ROWTIME_TIMESTAMPS_CLASS = "rowtime.timestamps.class"
- val ROWTIME_TIMESTAMPS_SERIALIZED = "rowtime.timestamps.serialized"
-
- val ROWTIME_WATERMARKS_TYPE = "rowtime.watermarks.type"
- val ROWTIME_WATERMARKS_TYPE_VALUE_PERIODIC_ASCENDING = "periodic-ascending"
- val ROWTIME_WATERMARKS_TYPE_VALUE_PERIODIC_BOUNDED = "periodic-bounded"
- val ROWTIME_WATERMARKS_TYPE_VALUE_FROM_SOURCE = "from-source"
- val ROWTIME_WATERMARKS_TYPE_VALUE_CUSTOM = "custom"
- val ROWTIME_WATERMARKS_CLASS = "rowtime.watermarks.class"
- val ROWTIME_WATERMARKS_SERIALIZED = "rowtime.watermarks.serialized"
- val ROWTIME_WATERMARKS_DELAY = "rowtime.watermarks.delay"
+ /**
+ * Use constants in [[Rowtime]] instead.
+ */
+ @Deprecated val ROWTIME = Rowtime.ROWTIME
Review comment:
Just remove those constants? RowtimeValidator is an internal class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
