dawidwys commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r276165393
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
##########
@@ -94,14 +94,14 @@ class SchemaValidator(
object SchemaValidator {
/**
- * Prefix for schema-related properties.
+ * Prefix for schema-related properties. Use constants in [[Schema]]
instead.
*/
- val SCHEMA = "schema"
+ @Deprecated val SCHEMA = Schema.SCHEMA
- val SCHEMA_NAME = "name"
- val SCHEMA_TYPE = "type"
- val SCHEMA_PROCTIME = "proctime"
- val SCHEMA_FROM = "from"
+ @Deprecated val SCHEMA_NAME = Schema.SCHEMA_NAME
Review comment:
Just remove constants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
