yanghua commented on a change in pull request #8199: [FLINK-11955] Modify build
to move filesystems from lib to plugins folder
URL: https://github.com/apache/flink/pull/8199#discussion_r276267262
##########
File path: flink-dist/pom.xml
##########
@@ -140,19 +140,54 @@ under the License.
</exclusions>
</dependency>
+ <!--
+ The following dependencies are packaged in 'plugin/'
+ The scope of these dependencies needs to be 'provided'
so that
+ they are not included into the 'flink-dist' uber jar.
+ -->
<!-- Default file system support. The Hadoop and MapR
dependencies -->
<!-- are optional, so not being added to the dist jar
-->
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-hadoop-fs</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
um... Actually, IMO, the merge-order of this PR should follow the order of
subtasks under the umbrella issue about the plugin architecture (FLINK-11952).
We should make sure the plugins work fine with the whole plugin architecture.
There still is an opening issue which is being implemented by @pnowojski. cc
@StefanRRichter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
