yanghua commented on a change in pull request #8199: [FLINK-11955] Modify build
to move filesystems from lib to plugins folder
URL: https://github.com/apache/flink/pull/8199#discussion_r276472293
##########
File path: flink-dist/pom.xml
##########
@@ -140,19 +140,54 @@ under the License.
</exclusions>
</dependency>
+ <!--
+ The following dependencies are packaged in 'plugin/'
+ The scope of these dependencies needs to be 'provided'
so that
+ they are not included into the 'flink-dist' uber jar.
+ -->
<!-- Default file system support. The Hadoop and MapR
dependencies -->
<!-- are optional, so not being added to the dist jar
-->
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-hadoop-fs</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
@zentol Maybe I did not describe my thought clearly, I just want to say this
PR is just an auxiliary work, it's final state will be decided by other works,
design, back compatibility and so on. I think the who architecture is still in
the exploration and testing stage.
I know that `flink-hadoop-fs` and `flink-mapr-fs` is been packaged into
`flink-dist` before. And I know this PR is not in the merge-ready state. I just
opened it, when the prior work is done, we will discuss how to deal with these
two filesystems. There may be two possibilities :
* follow the plugin architecture totally, there may other work should be
done as you said
* follow the plugin architecture partially, then these two modules should be
packaged into `dist` like before, but others will be shipped into `plugin` dir
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
