zhijiangW commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276280152
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -208,6 +219,8 @@ public void shutDown() throws FlinkException {
taskEventDispatcher.clearAll();
+ taskManagerMetricGroup.close();
Review comment:
That is true. We decide not to make `TaskManagerMetricGroup` as one
component of `TaskManagerServices`, so keep the previous behavior in
`TaskExecutor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
