zhijiangW commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276531613
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -357,15 +357,16 @@ public static TaskExecutor startTaskManager(
TaskManagerServices taskManagerServices =
TaskManagerServices.fromConfiguration(
taskManagerServicesConfiguration,
resourceID,
+ remoteAddress,
+ metricRegistry,
Review comment:
Considering the issue of
`NetworkEnviroment.fromConfiguration(configuration)`, we should decouple the
`NetworkEnvironmentConfiguration` from `TaskManagerServicesConfiguration` and
the current creation of `NetworkEnvironmentConfiguration` also relies on other
parameters such as `maxJvmHeapMemory`, `remoteAddress` and `localCommunication`.
So it might be involved in more refactoring to create `NetworkEnvironment`
from flink `Configuration` directly. Then I want to create a separate ticket
for this issue. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
