zentol commented on a change in pull request #8209: [FLINK-11889] Remove "stop" 
signal and related interfaces.
URL: https://github.com/apache/flink/pull/8209#discussion_r276653300
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobCancellationHandler.java
 ##########
 @@ -83,8 +84,7 @@ public JobTerminationHandler(
                                terminationFuture = gateway.cancelJob(jobId, 
timeout);
                                break;
                        case STOP:
-                               terminationFuture = gateway.stopJob(jobId, 
timeout);
-                               break;
+                               throw new RestHandlerException("The \"stop\" 
command is deprecated. Please use \"stop-with-savepoint\" instead.", 
HttpResponseStatus.PERMANENT_REDIRECT);
 
 Review comment:
   Instead of deprecated let's say that it was removed instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to