zentol commented on a change in pull request #8209: [FLINK-11889] Remove "stop"
signal and related interfaces.
URL: https://github.com/apache/flink/pull/8209#discussion_r276653330
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobCancellationHandler.java
##########
@@ -45,26 +44,28 @@
import java.util.concurrent.CompletionException;
import java.util.concurrent.TimeoutException;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
/**
* Request handler for the cancel and stop request.
*/
-public class JobTerminationHandler extends AbstractRestHandler<RestfulGateway,
EmptyRequestBody, EmptyResponseBody, JobTerminationMessageParameters> {
+public class JobCancellationHandler extends
AbstractRestHandler<RestfulGateway, EmptyRequestBody, EmptyResponseBody,
JobCancellationMessageParameters> {
private final TerminationModeQueryParameter.TerminationMode
defaultTerminationMode;
- public JobTerminationHandler(
+ public JobCancellationHandler(
GatewayRetriever<? extends RestfulGateway>
leaderRetriever,
Time timeout,
Map<String, String> headers,
- MessageHeaders<EmptyRequestBody, EmptyResponseBody,
JobTerminationMessageParameters> messageHeaders,
+ MessageHeaders<EmptyRequestBody, EmptyResponseBody,
JobCancellationMessageParameters> messageHeaders,
TerminationModeQueryParameter.TerminationMode
defaultTerminationMode) {
super(leaderRetriever, timeout, headers, messageHeaders);
- this.defaultTerminationMode =
Preconditions.checkNotNull(defaultTerminationMode);
+ this.defaultTerminationMode =
checkNotNull(defaultTerminationMode);
Review comment:
unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
