wuchong commented on a change in pull request #8203:
[Flink-12208][table-planner-blink] Support translation from StreamExecSort /
TemporalSort / SortLimit/ Limit to StreamTransformation.
URL: https://github.com/apache/flink/pull/8203#discussion_r277192284
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecSortLimit.scala
##########
@@ -97,5 +114,105 @@ class StreamExecSortLimit(
}
}
- // TODO check `fetch` is not null in translateToPlan
+ //~ ExecNode methods
-----------------------------------------------------------
+
+ override def getInputNodes: util.List[ExecNode[StreamTableEnvironment, _]] =
{
+ List(getInput.asInstanceOf[ExecNode[StreamTableEnvironment, _]])
+ }
+
+ override protected def translateToPlanInternal(
+ tableEnv: StreamTableEnvironment): StreamTransformation[BaseRow] = {
+ if (fetch == null) {
+ throw new TableException(
+ "FETCH is missed, which on streaming table is not supported currently")
+ }
+ val inputRowTypeInfo =
FlinkTypeFactory.toInternalRowType(getInput.getRowType).toTypeInfo
+ val fieldCollations = sortCollation.getFieldCollations
+ val (sortFields, sortDirections, nullsIsLast) =
SortUtil.getKeysAndOrders(fieldCollations)
+ val sortKeySelector = KeySelectorUtil.getBaseRowSelector(sortFields,
inputRowTypeInfo)
+ val sortKeyType = sortKeySelector.getProducedType
+ val tableConfig = tableEnv.getConfig
+ val sortKeyComparator = ComparatorCodeGenerator.gen(tableConfig,
"StreamExecSortComparator",
Review comment:
I would like to separate method parameters into multiple lines when method
call is long in Scala.
```scala
val sortKeyComparator = ComparatorCodeGenerator.gen(
tableConfig,
"StreamExecSortComparator",
sortFields.indices.toArray,
sortKeyType.getInternalTypes,
sortDirections,
nullsIsLast)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
