wuchong commented on a change in pull request #8203:
[Flink-12208][table-planner-blink] Support translation from StreamExecSort /
TemporalSort / SortLimit/ Limit to StreamTransformation.
URL: https://github.com/apache/flink/pull/8203#discussion_r277504403
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/runtime/stream/sql/RankITCase.scala
##########
@@ -1095,34 +1070,35 @@ class RankITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase(mode
assertEquals(updatedExpected.sorted, sink.getUpsertResults.sorted)
}
- // FIXME
- @Ignore("Enable after agg implements ExecNode")
@Test
def testMultipleRetractTopNAfterAgg(): Unit = {
Review comment:
I would like to ignore this test and revert the changes, because current
implementation lost the original test purpose, i.e. "test multiple retract sink
after topN".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
