hequn8128 commented on a change in pull request #8230: [FLINK-10977][table] Add
streaming non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#discussion_r277635116
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
##########
@@ -412,8 +428,28 @@ case class AggFunctionCall(
typeFactory,
aggregateFunction.requiresOver)
}
+}
- override private[flink] def toRexNode(implicit relBuilder: RelBuilder):
RexNode = {
- relBuilder.call(this.getSqlAggFunction(), args.map(_.toRexNode): _*)
+/**
+ * Expression for calling a user-defined table aggregate function.
+ */
+case class TableAggFunctionCall(
+ aggregateFunction: TableAggregateFunction[_, _],
Review comment:
Yes, once we unify `AggSqlFunction` we don't need this
`TableAggFunctionCall`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
