hequn8128 commented on a change in pull request #8230: [FLINK-10977][table] Add
streaming non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#discussion_r277637594
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/AggregateFunctionDefinition.java
##########
@@ -31,13 +31,13 @@
@PublicEvolving
public final class AggregateFunctionDefinition extends FunctionDefinition {
- private final AggregateFunction<?, ?> aggregateFunction;
+ private final UserDefinedAggregateFunction<?, ?> aggregateFunction;
private final TypeInformation<?> resultTypeInfo;
private final TypeInformation<?> accumulatorTypeInfo;
public AggregateFunctionDefinition(
String name,
- AggregateFunction<?, ?> aggregateFunction,
+ UserDefinedAggregateFunction<?, ?> aggregateFunction,
Review comment:
I'm not sure if it's right to add a new type of FunctionDefinition.
TableAggregate can somehow also be treated as an Aggregate function. Maybe we
can add this type later if we find it's needed. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
